#dev #cln
Today was a good day! On this morning's call with Alex we discovered the cause of a INVALID_ONION error which Elle had just reproduced: LND will still send legacy onions of it doesn't see a node's announcement. We removed support for that years ago, after it was removed from the spec. Still, before breakfast I had a working and tested implementation to sneak into rc2. Not happy about it, but interop wins over my feelings unfortunately!
https://github.com/ElementsProject/lightning/pull/7352
I also finished code to properly send reestablish messages for closed channels: we weren't doing this properly since some other code changes last release, preferring to send the last error we had. Which was just as well, because doing so was triggering a corner case where we could delay on chain cleanup on older versions (embarrassingly, my logs show this happened in my own node in Feb 2022, with v0.10.2: I thought it was broken because I messed with my DB using an experimental version!).
https://github.com/ElementsProject/lightning/pull/7353
Finally, I wrote a simple benchmark to vaguely simulate the slowdown/high CPU large nodes like Boltz are seeing: I wanted to this since Michael let me strace and profile their connnectd in Austin. The actual optimization was surprisingly trivial, and makes the time spent in poll() down to noise. As a bonus, I also implemented and tested gossip rate limiting (1MB per second). PR coming tomorrow!
Rusty Russell
npub179e…lz4s
2024-05-29 11:03:55
Author Public Key
npub179e9tp4yqtqx4myp35283fz64gxuzmr6n3yxnktux5pnd5t03eps0elz4sPublished at
2024-05-29 11:03:55Event JSON
{
"id": "5de30989d09b57e724a3559c80d9829764d9efff0cc88c6ffaeb9ad7424ff521",
"pubkey": "f1725586a402c06aec818d1478a45aaa0dc16c7a9c4869d97c350336d16f8e43",
"created_at": 1716973435,
"kind": 1,
"tags": [
[
"t",
"dev"
],
[
"t",
"cln"
],
[
"r",
"https://github.com/ElementsProject/lightning/pull/7352"
],
[
"r",
"https://github.com/ElementsProject/lightning/pull/7353"
]
],
"content": "#dev #cln\n\nToday was a good day! On this morning's call with Alex we discovered the cause of a INVALID_ONION error which Elle had just reproduced: LND will still send legacy onions of it doesn't see a node's announcement. We removed support for that years ago, after it was removed from the spec. Still, before breakfast I had a working and tested implementation to sneak into rc2. Not happy about it, but interop wins over my feelings unfortunately! \n\nhttps://github.com/ElementsProject/lightning/pull/7352\n\nI also finished code to properly send reestablish messages for closed channels: we weren't doing this properly since some other code changes last release, preferring to send the last error we had. Which was just as well, because doing so was triggering a corner case where we could delay on chain cleanup on older versions (embarrassingly, my logs show this happened in my own node in Feb 2022, with v0.10.2: I thought it was broken because I messed with my DB using an experimental version!).\n\nhttps://github.com/ElementsProject/lightning/pull/7353\n\nFinally, I wrote a simple benchmark to vaguely simulate the slowdown/high CPU large nodes like Boltz are seeing: I wanted to this since Michael let me strace and profile their connnectd in Austin. The actual optimization was surprisingly trivial, and makes the time spent in poll() down to noise. As a bonus, I also implemented and tested gossip rate limiting (1MB per second). PR coming tomorrow!",
"sig": "f92e21bb35714abb3f345e43872776c98ecd7c780566e588f11ad59d7069276f0068ccf7e0167521390e514e7c189118286e13a03561fb5015d9c605c3907b02"
}