📅 Original date posted:2013-10-04
📝 Original message:On Fri, Oct 4, 2013 at 1:53 PM, Peter Todd <pete at petertodd.org> wrote:
> When I'm reviewing multiple commit pull-requests and want to see every
> change made, I always either click on the "Files Changed" tab on github,
> which collapses every commit into a single diff, or do the equivalent
> with git log.
>
> Why doesn't that work for you?
>
The files changed tab definitely works better for reading. In the past
comments I put there have disappeared, but I think that can also be true of
comments put on the individual commit reviews (which is another issue with
github, but it's unrelated to how the commits are presented). So I have
lost trust in doing reviews that way. It does make things easier to read
though.
One advantage of using github is that they're an independent third
> party; we should think carefully about the risks of furthering the
> impression that Bitcoin development is a closed process by moving the
> code review it to a server that we control with explicit review groups.
>
I guess anyone would be able to sign up and comment.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linuxfoundation.org/pipermail/bitcoin-dev/attachments/20131004/8804a6e6/attachment.html>;
Mike Hearn [ARCHIVE] /
npub17t…4qgyd
2023-06-07 17:07:20
in reply to nevent1q…uf0m
Author Public Key
npub17ty4mumkv43w8wtt0xsz2jypck0gvw0j8xrcg6tpea25z2nh7meqf4qgydPublished at
2023-06-07 17:07:20Event JSON
{
"id": "dc74ad82f699126aa444dc7f029ddc09072005fa4325607a2d596bf034bd7922",
"pubkey": "f2c95df3766562e3b96b79a0254881c59e8639f23987846961cf55412a77f6f2",
"created_at": 1686150440,
"kind": 1,
"tags": [
[
"e",
"c5a68e6f904af4bb9ba26063f532146fb896046fee8fed7dd28cab691644cf81",
"",
"root"
],
[
"e",
"468352e89dc3b23b817c74d85d0d39eb289ffcd395d4ccd03d3ee3b1c7ff1b37",
"",
"reply"
],
[
"p",
"daa2fc676a25e3b5b45644540bcbd1e1168b111427cd0e3cf19c56194fb231aa"
]
],
"content": "📅 Original date posted:2013-10-04\n📝 Original message:On Fri, Oct 4, 2013 at 1:53 PM, Peter Todd \u003cpete at petertodd.org\u003e wrote:\n\n\u003e When I'm reviewing multiple commit pull-requests and want to see every\n\u003e change made, I always either click on the \"Files Changed\" tab on github,\n\u003e which collapses every commit into a single diff, or do the equivalent\n\u003e with git log.\n\u003e\n\u003e Why doesn't that work for you?\n\u003e\n\nThe files changed tab definitely works better for reading. In the past\ncomments I put there have disappeared, but I think that can also be true of\ncomments put on the individual commit reviews (which is another issue with\ngithub, but it's unrelated to how the commits are presented). So I have\nlost trust in doing reviews that way. It does make things easier to read\nthough.\n\nOne advantage of using github is that they're an independent third\n\u003e party; we should think carefully about the risks of furthering the\n\u003e impression that Bitcoin development is a closed process by moving the\n\u003e code review it to a server that we control with explicit review groups.\n\u003e\n\nI guess anyone would be able to sign up and comment.\n-------------- next part --------------\nAn HTML attachment was scrubbed...\nURL: \u003chttp://lists.linuxfoundation.org/pipermail/bitcoin-dev/attachments/20131004/8804a6e6/attachment.html\u003e",
"sig": "2b09030ddf85ab4f089c6f015e2be365bf1db885317866ab02c58fe210ca53ad9012cb040e60de868840a2940d0feab0643970b83c2acb20764c70a0d8394646"
}