Lagrange on Nostr: I have been fixing renepay lately and thanks to some insightful discussions and ...
I have been fixing renepay lately and thanks to some insightful discussions and brainstorming with René Pickhardt we have had great improvements.
In summary, the current Mininum Cost Flow algorithm (MCF) cannot allocate fees as part of the payment amount due to the sats conservation assumption that the only source and sink of flow are the sender and recipient nodes. Once fees are added on top this resulted in channels being asked to forward more sats than their probable available liquidity and consequently possibly an infinite loop of failures. To fix this we take the routes computed by the MCF and reduce their sending amount to fit all liquidity constraints:
fee, uncertainty and max_htlc; then deficit in the delivering amount is redistributed among the other routes or reallocated in a new MCF computation if necessary.
More details at this PR:
https://github.com/ElementsProject/lightning/pull/6893before:
after:
Published at
2023-11-24 08:45:29Event JSON
{
"id": "9c408c788f10bf9012bbd22b95c01be7311fced8e0c0a719746c2b98c9e2e5bb",
"pubkey": "0022fc3af01bafe1766437b87d92db4dd22cbd108ab044aaa0053cdc2f9d9f79",
"created_at": 1700811929,
"kind": 1,
"tags": [],
"content": "I have been fixing renepay lately and thanks to some insightful discussions and brainstorming with René Pickhardt we have had great improvements. \n\nIn summary, the current Mininum Cost Flow algorithm (MCF) cannot allocate fees as part of the payment amount due to the sats conservation assumption that the only source and sink of flow are the sender and recipient nodes. Once fees are added on top this resulted in channels being asked to forward more sats than their probable available liquidity and consequently possibly an infinite loop of failures. To fix this we take the routes computed by the MCF and reduce their sending amount to fit all liquidity constraints: \nfee, uncertainty and max_htlc; then deficit in the delivering amount is redistributed among the other routes or reallocated in a new MCF computation if necessary.\n\nMore details at this PR: https://github.com/ElementsProject/lightning/pull/6893\n\nbefore:\nhttps://image.nostr.build/08ae35b68c3e9f09b8bda1574e452bb9bbe490c4921ee875af5adb9da274f10e.png\n\nafter:\nhttps://image.nostr.build/718c55cd82260ed86a32bfa2cbc24af0137cae58ba56dd9d0c5f931483d2de21.png\n\n",
"sig": "8143742104cfce59167992466cd80aef81d9473429fe780ac866b109806769e562ebe88ebf1ab9308496ab39a89ac452c1961112343ad284754405d7ba4b15a0"
}
