[#1530] Create new controls UI for video playback (#1537)
Addresses #1530
Create a new controls UI layer for the DamusVideoPlayer, providing play/pause, volume control, content scale, playback rate controls, as well as a seek/timecode bar.
<img width="594" alt="Screenshot 2023-09-05 at 11 42 46" src="https://github.com/damus-io/damus/assets/1031501/de89196e-0951-4a59-8430-99a8cd166e60">;
<img width="586" alt="Screenshot 2023-09-05 at 11 42 55" src="https://github.com/damus-io/damus/assets/1031501/4a947870-640d-4c7e-89f7-1eab30326aa3">;
Current features:
- Scrub on the horizontal seek bar to change the playback time
- Play/Pause button
- Mute/Unmute button and volume vertical slider
- Select playback rate from 0.5x up to 2.0x
- Tap video to hide/show controls
- Player has option to hide controls on startup
- Player's video tap behavior can be customized
Fixes:
- The VideoPlayer has been reworked from frame-by-frame updating to an event-driven model, significantly improving performance and understandability.
Known Issues:
- This still suffers from [#1386] as that is a navigation/data model architecture issue, not specific to the video player.
Note:
- This feature DOES NOT INCLUDE A FIX FOR #1386 ! That fix will be provided in a future PR.
Bounty: 100k satoshis(BTC) -> 0.001 BTC
Payout Address: `bc1q5sxugecyhq5stxn4d79p4908hdr7ljcn35uyk7`
<img width="341" alt="btc001" src="https://github.com/damus-io/damus/assets/1031501/54552b4f-ad4e-4842-b1a2-2ac44bf47ad7">;
issue/1530-video-controls, 2 commits
https://github.com/damus-io/damus/pull/1537
prs / Damus PRs
npub1ah…y7v97
2023-09-05 17:47:35
Author Public Key
npub1ahckk8wkr64n2w5r4arsesf42upfhlmgy76vhxmlex7mvv4zhrnqry7v97Published at
2023-09-05 17:47:35Event JSON
{
"id": "10b288b175fc34f87c3e31ad4ce6e3eaec22f3dd4f5d7d3fb3f1f11a7f1c9283",
"pubkey": "edf16b1dd61eab353a83af470cc13557029bff6827b4cb9b7fc9bdb632a2b8e6",
"created_at": 1693928855,
"kind": 1,
"tags": [
[
"p",
"32e1827635450ebb3c5a7d12c1f8e7b2b514439ac10a67eef3d9fd9c5c68e245"
],
[
"t",
"damuspr"
]
],
"content": "[#1530] Create new controls UI for video playback (#1537)\n\nAddresses #1530\r\n\r\nCreate a new controls UI layer for the DamusVideoPlayer, providing play/pause, volume control, content scale, playback rate controls, as well as a seek/timecode bar.\r\n\r\n\u003cimg width=\"594\" alt=\"Screenshot 2023-09-05 at 11 42 46\" src=\"https://github.com/damus-io/damus/assets/1031501/de89196e-0951-4a59-8430-99a8cd166e60\"\u003e\r\n\u003cimg width=\"586\" alt=\"Screenshot 2023-09-05 at 11 42 55\" src=\"https://github.com/damus-io/damus/assets/1031501/4a947870-640d-4c7e-89f7-1eab30326aa3\"\u003e\r\n\r\nCurrent features:\r\n- Scrub on the horizontal seek bar to change the playback time\r\n- Play/Pause button\r\n- Mute/Unmute button and volume vertical slider\r\n- Select playback rate from 0.5x up to 2.0x\r\n- Tap video to hide/show controls\r\n- Player has option to hide controls on startup\r\n- Player's video tap behavior can be customized\r\nFixes:\r\n- The VideoPlayer has been reworked from frame-by-frame updating to an event-driven model, significantly improving performance and understandability.\r\nKnown Issues:\r\n- This still suffers from [#1386] as that is a navigation/data model architecture issue, not specific to the video player.\r\nNote:\r\n- This feature DOES NOT INCLUDE A FIX FOR #1386 ! That fix will be provided in a future PR.\r\n\r\nBounty: 100k satoshis(BTC) -\u003e 0.001 BTC\r\nPayout Address: `bc1q5sxugecyhq5stxn4d79p4908hdr7ljcn35uyk7`\r\n\u003cimg width=\"341\" alt=\"btc001\" src=\"https://github.com/damus-io/damus/assets/1031501/54552b4f-ad4e-4842-b1a2-2ac44bf47ad7\"\u003e\r\n\r\n\n\nissue/1530-video-controls, 2 commits\n\nhttps://github.com/damus-io/damus/pull/1537",
"sig": "3c7dd78df8c456e5f8324a964d2c115fcebf28939d9a791cca8ecb6254b0e3f86cc565d346db927bbde10abed918bff24c000b89db430dea3b2db610d15976bc"
}