📅 Original date posted:2023-06-30
🗒️ Summary of this message: This pull request proposes to remove certain features from the code based on recent releases and node announcements, simplifying the code.
📝 Original message:
https://github.com/lightning/bolts/pull/1092
02-peer-protocol.md | 74 ++-------
03-transactions.md | 389 ---------------------------------------------------
05-onchain.md | 17 --
07-routing-gossip.md | 52 +-----
09-features.md | 30 +--
5 files changed, 48 insertions(+), 514 deletions(-)
Simplicity FTW. This PR proposes to start ignoring
(and thus, simply assuming) various features, based on recent releases
and scanning node announcments:
Removed:
* initial_routing_sync (only had an effect if gossip_queries not supported)
* option_anchor_outputs (only supported by older experimental-only CLN builds)
I looked at all node_announcements on my node. There are 449 nodes apparently running a 4-year-old LND version (features hex 2200), which have 3+ year old channels. @Roasbeef points out that they already will have their channel_updates ignored due to lack of htlc_maximum_msat which is now required by LND and CLN, at least).
Features you can now assume (you should probably still set it for now, but you can stop checking it).
* var_onion_optin (all but 6 nodes)
* gossip_queries (all but 11 nodes)
* option_data_loss_protect (all but 11 nodes)
* option_static_remotekey (all but 16 nodes)
Cheers!
Rusty.
Rusty Russell [ARCHIVE] /
npub1zw…hkhpx
2023-07-03 11:29:50
in reply to nevent1q…u88x
Author Public Key
npub1zw7cc8z78v6s3grujfvcv3ckpvg6kr0w7nz9yzvwyglyg0qu5sjsqhkhpxPublished at
2023-07-03 11:29:50Event JSON
{
"id": "ecd46617c824acbd51790c85e2c42c7853c3afb03ea3ebee94577f010045d178",
"pubkey": "13bd8c1c5e3b3508a07c92598647160b11ab0deef4c452098e223e443c1ca425",
"created_at": 1688376590,
"kind": 1,
"tags": [
[
"e",
"7180153267980037a4c797a07fadb3d9ebf6c9797a0dd341d833877819c80e9e",
"",
"reply"
],
[
"p",
"9456f7acb763eaab2e02bd8e60cf17df74f352c2ae579dce1f1dd25c95dd611c"
]
],
"content": "📅 Original date posted:2023-06-30\n🗒️ Summary of this message: This pull request proposes to remove certain features from the code based on recent releases and node announcements, simplifying the code.\n📝 Original message:\nhttps://github.com/lightning/bolts/pull/1092\n\n 02-peer-protocol.md | 74 ++-------\n 03-transactions.md | 389 ---------------------------------------------------\n 05-onchain.md | 17 --\n 07-routing-gossip.md | 52 +-----\n 09-features.md | 30 +--\n 5 files changed, 48 insertions(+), 514 deletions(-)\n\nSimplicity FTW. This PR proposes to start ignoring\n(and thus, simply assuming) various features, based on recent releases\nand scanning node announcments:\n\nRemoved:\n\n* initial_routing_sync (only had an effect if gossip_queries not supported)\n* option_anchor_outputs (only supported by older experimental-only CLN builds)\n\nI looked at all node_announcements on my node. There are 449 nodes apparently running a 4-year-old LND version (features hex 2200), which have 3+ year old channels. @Roasbeef points out that they already will have their channel_updates ignored due to lack of htlc_maximum_msat which is now required by LND and CLN, at least).\n\nFeatures you can now assume (you should probably still set it for now, but you can stop checking it).\n\n* var_onion_optin (all but 6 nodes)\n* gossip_queries (all but 11 nodes)\n* option_data_loss_protect (all but 11 nodes)\n* option_static_remotekey (all but 16 nodes)\n\nCheers!\nRusty.",
"sig": "ae3d7143e9b4cb30b0dd7a09fdede9a71334aaea036b0e574f62b6a4dbe73204af0e5b5e85d4c9d1c884828d26474288c78836a87cc415e8575f911f87b67e89"
}