Awesome work on this kukks (npub1y24…z2ad). It works smoothly out of the box.
2 things I noticed:
1. Zappr private key should be allowed (optionally) to be different than the zap recipients private key. Ideally delegation could be accepted here too.
2. If someone tries to pass a comment with the zap, the invoice generation fails.
Mazin
npub18kz…x5sz
2023-04-15 05:13:11
in reply to nevent1q…ufmc
Author Public Key
npub18kzz4lkdtc5n729kvfunxuz287uvu9f64ywhjz43ra482t2y5sks0mx5szPublished at
2023-04-15 05:13:11Event JSON
{
"id": "8636e717b855417bbbf1ff8a997a00aeaf71892a06682a6c620c86480231b44b",
"pubkey": "3d842afecd5e293f28b6627933704a3fb8ce153aa91d790ab11f6a752d44a42d",
"created_at": 1681528391,
"kind": 1,
"tags": [
[
"e",
"ee2886380d96d6d76382034e5a28709c694c600a874e2a97b82743660859f97f",
""
],
[
"e",
"ba45f58e0adee22fda2d96e1fe1e6aea9149746c460886b2c8aee163b6021cd1"
],
[
"p",
"a536ab1f7f3c0133baadbdf472b1ac7ad4b774ed432c1989284193572788bca0"
],
[
"p",
"3f770d65d3a764a9c5cb503ae123e62ec7598ad035d836e2a810f3877a745b24"
],
[
"p",
"22aa81510ee63fe2b16cae16e0921f78e9ba9882e2868e7e63ad6d08ae9b5954",
""
],
[
"p",
"469179475d290add06ac15460d08e370c06deb2cffe7fbd96ad6694b948f0683",
""
],
[
"p",
"91c9a5e1a9744114c6fe2d61ae4de82629eaaa0fb52f48288093c7e7e036f832"
]
],
"content": "Awesome work on this #[4]. It works smoothly out of the box. \n\n2 things I noticed:\n\n1. Zappr private key should be allowed (optionally) to be different than the zap recipients private key. Ideally delegation could be accepted here too. \n\n2. If someone tries to pass a comment with the zap, the invoice generation fails.",
"sig": "8b910eb7c4c13f63e2bddb37787d4bef18861231bf12b34e1801374e8e6a375e8782055f68fd1e77a63ebe5045485b406381b0d411055d4191d041a5344c1669"
}